Added support for multiple parameters to Extension API callbacks.

chrome/browser/extensions/extension_function.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_FUNCTION_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_FUNCTION_H_
 #pragma once
 
 #include <list>
 #include <string>
@@ skipping 90 matching lines @@
   virtual void GetQuotaLimitHeuristics(
       QuotaLimitHeuristics* heuristics) const {}
 
   // Called when the quota limit has been exceeded. The default implementation
   // returns an error.
   virtual void OnQuotaExceeded();
 
   // Specifies the raw arguments to the function, as a JSON value.
   virtual void SetArgs(const base::ListValue* args);
 
-  // Retrieves the results of the function as a Value.
-  const base::Value* GetResultValue();
+  // Sets a single Value as the results of the function.
+  void SetSingleResult(base::Value* result);

[Matt Perry, 2012/07/09 23:52:25]

IMO, Single is redundant here given that Result is singular. I think SetResult
is fine. I'd imagine the other version would be SetResultList, and/or take a
ListValue, or something.

[Matt Tytel, 2012/07/10 18:50:45]

Done.

[Aaron Boodman, 2012/07/10 20:34:22]

Can you change the GetResults->GetResultList? Having methods  differ by a single
character is confusing.

[Matt Tytel, 2012/07/10 20:54:28]

Done.

+
+  // Retrieves the results of the function as a ListValue.
+  const base::ListValue* GetResults();
 
   // Retrieves any error string from the function.
   virtual const std::string GetError();
 
   // Sets the function's error string.
   virtual void SetError(const std::string& error);
 
   // Specifies the name of the function.
   void set_name(const std::string& name) { name_ = name; }
   const std::string& name() const { return name_; }
@@ skipping 76 matching lines @@
   // mode extension, this will always be false, and we will limit access to
   // data from within the same profile_ (either incognito or not).
   bool include_incognito_;
 
   // True if the call was made in response of user gesture.
   bool user_gesture_;
 
   // The arguments to the API. Only non-null if argument were specified.
   scoped_ptr<base::ListValue> args_;
 
-  // The result of the API. This should be populated by the derived class before
-  // SendResponse() is called.
-  scoped_ptr<base::Value> result_;
+  // The results of the API. This should be populated by the derived class
+  // before SendResponse() is called.
+  scoped_ptr<base::ListValue> results_;
 
   // Any detailed error from the API. This should be populated by the derived
   // class before Run() returns.
   std::string error_;
 
   // Any class that gets a malformed message should set this to true before
   // returning.  The calling renderer process will be killed.
   bool bad_message_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionFunction);
@@ skipping 198 matching lines @@
  public:
   SyncIOThreadExtensionFunction();
 
   virtual void Run() OVERRIDE;
 
  protected:
   virtual ~SyncIOThreadExtensionFunction();
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_FUNCTION_H_