chrome/browser/history/top_sites_extension_api.cc - Issue 10694106: Added support for multiple parameters to Extension API callbacks.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/history/top_sites_extension_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Synced. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/extension_function.cc ('K') | « chrome/browser/history/history_extension_api.cc ('k') | chrome/browser/history/top_sites_extension_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/history/top_sites_extension_api.h"	5 #include "chrome/browser/history/top_sites_extension_api.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "base/values.h"	8 #include "base/values.h"

9 #include "chrome/browser/history/top_sites.h"	9 #include "chrome/browser/history/top_sites.h"

10 #include "chrome/browser/profiles/profile.h"	10 #include "chrome/browser/profiles/profile.h"

(...skipping 23 matching lines...) Expand all Loading...
34 DictionaryValue* page_value = new DictionaryValue();	34 DictionaryValue* page_value = new DictionaryValue();

35 page_value->SetString("url", url.url.spec());	35 page_value->SetString("url", url.url.spec());

36 if (url.title.empty())	36 if (url.title.empty())

37 page_value->SetString("title", url.url.spec());	37 page_value->SetString("title", url.url.spec());

38 else	38 else

39 page_value->SetString("title", url.title);	39 page_value->SetString("title", url.title);

40 pages_value->Append(page_value);	40 pages_value->Append(page_value);

41 }	41 }

42 }	42 }

43	43

44 result_.reset(pages_value.release());	44 SetResult(pages_value.release());

45 SendResponse(true);	45 SendResponse(true);

46 }	46 }

OLD	NEW