Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: chrome/browser/extensions/api/serial/serial_apitest.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Synced. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 #include <vector> 6 #include <vector>
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "chrome/browser/extensions/api/api_resource_event_notifier.h" 9 #include "chrome/browser/extensions/api/api_resource_event_notifier.h"
10 #include "chrome/browser/extensions/api/serial/serial_api.h" 10 #include "chrome/browser/extensions/api/serial/serial_api.h"
(...skipping 21 matching lines...) Expand all
32 } // namespace 32 } // namespace
33 33
34 namespace extensions { 34 namespace extensions {
35 35
36 class FakeSerialGetPortsFunction : public AsyncExtensionFunction { 36 class FakeSerialGetPortsFunction : public AsyncExtensionFunction {
37 public: 37 public:
38 virtual bool RunImpl() { 38 virtual bool RunImpl() {
39 ListValue* ports = new ListValue(); 39 ListValue* ports = new ListValue();
40 ports->Append(Value::CreateStringValue("/dev/fakeserial")); 40 ports->Append(Value::CreateStringValue("/dev/fakeserial"));
41 ports->Append(Value::CreateStringValue("\\\\COM800\\")); 41 ports->Append(Value::CreateStringValue("\\\\COM800\\"));
42 result_.reset(ports); 42 SetResult(ports);
43 SendResponse(true); 43 SendResponse(true);
44 return true; 44 return true;
45 } 45 }
46 protected: 46 protected:
47 virtual ~FakeSerialGetPortsFunction() {} 47 virtual ~FakeSerialGetPortsFunction() {}
48 }; 48 };
49 49
50 class FakeEchoSerialConnection : public SerialConnection { 50 class FakeEchoSerialConnection : public SerialConnection {
51 public: 51 public:
52 explicit FakeEchoSerialConnection( 52 explicit FakeEchoSerialConnection(
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 183
184 ASSERT_TRUE(RunExtensionTest("serial/api")) << message_; 184 ASSERT_TRUE(RunExtensionTest("serial/api")) << message_;
185 } 185 }
186 186
187 IN_PROC_BROWSER_TEST_F(SerialApiTest, SerialRealHardware) { 187 IN_PROC_BROWSER_TEST_F(SerialApiTest, SerialRealHardware) {
188 ResultCatcher catcher; 188 ResultCatcher catcher;
189 catcher.RestrictToProfile(browser()->profile()); 189 catcher.RestrictToProfile(browser()->profile());
190 190
191 ASSERT_TRUE(RunExtensionTest("serial/real_hardware")) << message_; 191 ASSERT_TRUE(RunExtensionTest("serial/real_hardware")) << message_;
192 } 192 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698