Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4660)

Unified Diff: chrome/renderer/resources/extensions/event.js

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Build fix. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/event.js
diff --git a/chrome/renderer/resources/extensions/event.js b/chrome/renderer/resources/extensions/event.js
index a6d636342eea978f3568208f7345f8b763559306..397ebc3b4e03dedf1d4d7ed064ee46643fa245e8 100644
--- a/chrome/renderer/resources/extensions/event.js
+++ b/chrome/renderer/resources/extensions/event.js
@@ -133,18 +133,11 @@
eventArgumentMassagers[name] = fn;
};
- // Dispatches a named event with the given JSON array, which is deserialized
- // before dispatch. The JSON array is the list of arguments that will be
- // sent with the event callback.
- chromeHidden.Event.dispatchJSON = function(name, args) {
+ // Dispatches a named event with the given argument array. The args array is
+ // the list of arguments that will be sent to the event callback.
+ chromeHidden.Event.dispatch = function(name, args) {
if (attachedNamedEvents[name]) {
if (args) {
- // TODO(asargent): This is an antiquity. Until all callers of
- // dispatchJSON use actual values, this must remain here to catch the
- // cases where a caller has hard-coded a JSON string to pass in.
- if (typeof(args) == "string") {
- args = chromeHidden.JSON.parse(args);
- }
if (eventArgumentMassagers[name])
eventArgumentMassagers[name](args);
}

Powered by Google App Engine
This is Rietveld 408576698