Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2476)

Unified Diff: chrome/browser/history/history_extension_api.h

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing memory leak in a test. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/window_event_router.cc ('k') | chrome/browser/history/history_extension_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_extension_api.h
diff --git a/chrome/browser/history/history_extension_api.h b/chrome/browser/history/history_extension_api.h
index b026b7ca6446dea1dd804eb11d509cc181fea9ec..820cf64a3632fbd75add27dc4781b2f8881df035 100644
--- a/chrome/browser/history/history_extension_api.h
+++ b/chrome/browser/history/history_extension_api.h
@@ -16,6 +16,10 @@
#include "chrome/common/extensions/api/history.h"
#include "content/public/browser/notification_registrar.h"
+namespace base {
+class ListValue;
+}
+
typedef std::vector<linked_ptr<
extensions::api::history::HistoryItem> > HistoryItemList;
typedef std::vector<linked_ptr<
@@ -44,7 +48,7 @@ class HistoryExtensionEventRouter : public content::NotificationObserver {
void DispatchEvent(Profile* profile,
const char* event_name,
- const std::string& json_args);
+ scoped_ptr<base::ListValue> event_args);
// Used for tracking registrations to history service notifications.
content::NotificationRegistrar registrar_;
« no previous file with comments | « chrome/browser/extensions/window_event_router.cc ('k') | chrome/browser/history/history_extension_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698