Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6206)

Unified Diff: chrome/browser/extensions/api/push_messaging/push_messaging_api.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing memory leak in a test. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/push_messaging/push_messaging_api.cc
diff --git a/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc b/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc
index aaa36a50af7813ba08a920ffc2c41f870c298377..cc92f87bf20c337da9829d319bb89c3c14820560 100644
--- a/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc
+++ b/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc
@@ -34,11 +34,11 @@ void PushMessagingEventRouter::OnMessage(const std::string& extension_id,
message.subchannel_id = subchannel;
message.payload = payload;
- scoped_ptr<base::Value> parameters(glue::OnMessage::Create(message));
+ scoped_ptr<base::ListValue> args(glue::OnMessage::Create(message));
profile_->GetExtensionEventRouter()->DispatchEventToExtension(
extension_id,
event_names::kOnPushMessage,
- *parameters.get(),
+ args.Pass(),
profile_,
GURL());
}
« no previous file with comments | « chrome/browser/extensions/api/proxy/proxy_api.cc ('k') | chrome/browser/extensions/api/runtime/runtime_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698