Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2845)

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing memory leak in a test. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/management/management_api.cc
diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc
index 0af965c53154e2d883333c6ca9ad0991a3c6102a..667b9e4526e5ffaedcce9c58d1c1c8d0e8764d43 100644
--- a/chrome/browser/extensions/api/management/management_api.cc
+++ b/chrome/browser/extensions/api/management/management_api.cc
@@ -592,9 +592,9 @@ void ExtensionManagementEventRouter::Observe(
return;
}
- ListValue args;
+ scoped_ptr<ListValue> args(new ListValue());
if (event_name == events::kOnExtensionUninstalled) {
- args.Append(Value::CreateStringValue(
+ args->Append(Value::CreateStringValue(
content::Details<const extensions::Extension>(details).ptr()->id()));
} else {
const Extension* extension = NULL;
@@ -606,12 +606,9 @@ void ExtensionManagementEventRouter::Observe(
}
CHECK(extension);
ExtensionService* service = profile->GetExtensionService();
- args.Append(CreateExtensionInfo(*extension, service));
+ args->Append(CreateExtensionInfo(*extension, service));
}
- std::string args_json;
- base::JSONWriter::Write(&args, &args_json);
-
profile->GetExtensionEventRouter()->DispatchEventToRenderers(
- event_name, args_json, NULL, GURL(), extensions::EventFilteringInfo());
+ event_name, args.Pass(), NULL, GURL(), extensions::EventFilteringInfo());
}

Powered by Google App Engine
This is Rietveld 408576698