Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing memory leak in a test. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/downloads/downloads_api.cc
diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc
index bbfe75d755619ac13d455bc1404cd22c1b9eb7fd..8c304dbaa93e114b101aa997f64a090a065ce479 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api.cc
+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc
@@ -918,13 +918,14 @@ void ExtensionDownloadsEventRouter::ManagerGoingDown(
void ExtensionDownloadsEventRouter::DispatchEvent(
const char* event_name, base::Value* arg) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- base::ListValue args;
- args.Append(arg);
+ scoped_ptr<ListValue> args(new ListValue());
+ args->Append(arg);
std::string json_args;
- base::JSONWriter::Write(&args, &json_args);
+ base::JSONWriter::Write(args.get(), &json_args);
+
profile_->GetExtensionEventRouter()->DispatchEventToRenderers(
event_name,
- json_args,
+ args.Pass(),
profile_,
GURL(),
extensions::EventFilteringInfo());
« no previous file with comments | « chrome/browser/extensions/api/debugger/debugger_api.cc ('k') | chrome/browser/extensions/api/idle/idle_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698