Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: chrome/browser/chromeos/extensions/bluetooth_event_router.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing memory leak in a test. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/bluetooth_event_router.cc
diff --git a/chrome/browser/chromeos/extensions/bluetooth_event_router.cc b/chrome/browser/chromeos/extensions/bluetooth_event_router.cc
index 8cd0b0c61442555914aec47feb195201aec83228..7fec7e5925971d1151049672e3056b534e3de3b7 100644
--- a/chrome/browser/chromeos/extensions/bluetooth_event_router.cc
+++ b/chrome/browser/chromeos/extensions/bluetooth_event_router.cc
@@ -114,29 +114,25 @@ void ExtensionBluetoothEventRouter::DeviceAdded(
extensions::api::experimental_bluetooth::BluetoothDeviceToApiDevice(
*device, &extension_device);
- ListValue args;
- args.Append(extension_device.ToValue().release());
- std::string json_args;
- base::JSONWriter::Write(&args, &json_args);
+ scoped_ptr<ListValue> args(new ListValue());
+ args->Append(extension_device.ToValue().release());
profile_->GetExtensionEventRouter()->DispatchEventToRenderers(
extensions::event_names::kBluetoothOnDeviceDiscovered,
- json_args,
+ args.Pass(),
NULL,
GURL());
}
void ExtensionBluetoothEventRouter::DispatchBooleanValueEvent(
const char* event_name, bool value) {
- ListValue args;
- args.Append(Value::CreateBooleanValue(value));
- std::string json_args;
- base::JSONWriter::Write(&args, &json_args);
+ scoped_ptr<ListValue> args(new ListValue());
+ args->Append(Value::CreateBooleanValue(value));
// TODO(bryeung): only dispatch the event to interested renderers
// crbug.com/133179
profile_->GetExtensionEventRouter()->DispatchEventToRenderers(
- event_name, json_args, NULL, GURL());
+ event_name, args.Pass(), NULL, GURL());
}
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698