Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Unified Diff: chrome/browser/bookmarks/bookmark_manager_extension_api.h

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing memory leak in a test. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_manager_extension_api.h
diff --git a/chrome/browser/bookmarks/bookmark_manager_extension_api.h b/chrome/browser/bookmarks/bookmark_manager_extension_api.h
index dd2e29b4ab0d78e7deacdabc55cb6efa02ae51c3..af5e42717fa2da13a06a610dfffa5126747834d1 100644
--- a/chrome/browser/bookmarks/bookmark_manager_extension_api.h
+++ b/chrome/browser/bookmarks/bookmark_manager_extension_api.h
@@ -5,6 +5,7 @@
#ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_MANAGER_EXTENSION_API_H_
#define CHROME_BROWSER_BOOKMARKS_BOOKMARK_MANAGER_EXTENSION_API_H_
+#include "base/values.h"
#include "chrome/browser/bookmarks/bookmark_extension_api.h"
#include "chrome/browser/bookmarks/bookmark_node_data.h"
#include "chrome/browser/extensions/extension_function.h"
@@ -14,10 +15,6 @@ struct BookmarkNodeData;
class Profile;
class TabContents;
-namespace base {
-class ListValue;
-}
-
// Class that handles the chrome.experimental.bookmarkManager events.
class BookmarkManagerExtensionEventRouter
: public BookmarkTabHelper::BookmarkDrag {
@@ -40,7 +37,8 @@ class BookmarkManagerExtensionEventRouter
private:
// Helper to actually dispatch an event to extension listeners.
- void DispatchEvent(const char* event_name, const base::ListValue* args);
+ void DispatchEvent(const char* event_name,
+ scoped_ptr<base::ListValue> args);
void DispatchDragEvent(const BookmarkNodeData& data, const char* event_name);
« no previous file with comments | « chrome/browser/bookmarks/bookmark_extension_api.cc ('k') | chrome/browser/bookmarks/bookmark_manager_extension_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698