Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Unified Diff: chrome/browser/extensions/extension_management_api.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and review changes. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_management_api.cc
diff --git a/chrome/browser/extensions/extension_management_api.cc b/chrome/browser/extensions/extension_management_api.cc
index df9fd2d5ef97237e6487c9ec20d0a0b6e30eea33..727101e83a5f13b498051d1e6f30c0c14093be32 100644
--- a/chrome/browser/extensions/extension_management_api.cc
+++ b/chrome/browser/extensions/extension_management_api.cc
@@ -569,9 +569,9 @@ void ExtensionManagementEventRouter::Observe(
return;
}
- ListValue args;
+ ListValue* args = new ListValue();
if (event_name == events::kOnExtensionUninstalled) {
- args.Append(Value::CreateStringValue(
+ args->Append(Value::CreateStringValue(
*content::Details<const std::string>(details).ptr()));
} else {
const Extension* extension = NULL;
@@ -583,12 +583,9 @@ void ExtensionManagementEventRouter::Observe(
}
CHECK(extension);
ExtensionService* service = profile->GetExtensionService();
- args.Append(CreateExtensionInfo(*extension, service));
+ args->Append(CreateExtensionInfo(*extension, service));
}
- std::string args_json;
- base::JSONWriter::Write(&args, &args_json);
-
profile->GetExtensionEventRouter()->DispatchEventToRenderers(
- event_name, args_json, NULL, GURL(), extensions::EventFilteringInfo());
+ event_name, args, NULL, GURL(), extensions::EventFilteringInfo());
}

Powered by Google App Engine
This is Rietveld 408576698