Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7509)

Unified Diff: chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and review changes. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc
diff --git a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc
index 28bb985a08579b75e27a34a384c97cb7f9e36a98..6f53d033cb3ec6ecbf8346c17ffbb3d28d1c1ee0 100644
--- a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc
+++ b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc
@@ -264,19 +264,17 @@ void OffscreenTab::Observe(int type,
changed_properties->SetString(
tabs_keys::kUrlKey, web_contents()->GetURL().spec());
- ListValue args;
- args.Append(Value::CreateIntegerValue(
+ ListValue* args = new ListValue();
+ args->Append(Value::CreateIntegerValue(
ExtensionTabUtil::GetTabId(web_contents())));
- args.Append(changed_properties);
- args.Append(CreateValue());
- std::string json_args;
- base::JSONWriter::Write(&args, &json_args);
+ args->Append(changed_properties);
+ args->Append(CreateValue());
// The event router only dispatches the event to renderers listening for the
// event.
Profile* profile = parent_tab_->tab_contents()->profile();
profile->GetExtensionEventRouter()->DispatchEventToRenderers(
- events::kOnOffscreenTabUpdated, json_args, profile, GURL(),
+ events::kOnOffscreenTabUpdated, args, profile, GURL(),
extensions::EventFilteringInfo());
}

Powered by Google App Engine
This is Rietveld 408576698