Add the JS helper function to all libraries where we allow the native syntax.

lib/compiler/implementation/native_handler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('native');
 #import('dart:uri');
 #import('leg.dart');
 #import('elements/elements.dart');
 #import('scanner/scannerlib.dart');
 #import('ssa/ssa.dart');
@@ skipping 63 matching lines @@
 
 void maybeEnableNative(Compiler compiler,
                        LibraryElement library,
                        Uri uri) {
   String libraryName = uri.toString();
   if (library.script.name.contains('dart/tests/compiler/dart2js_native')
       || libraryName == 'dart:dom_deprecated'
       || libraryName == 'dart:isolate'
       || libraryName == 'dart:html') {
     library.canUseNative = true;
+    library.define(compiler.findHelper(const SourceString('JS')), compiler);

[Lasse Reichstein Nielsen, 2012/07/04 13:49:44]

Maybe we should extend the map in library_map.dart to a proper central "dart
library configuration", so we can store information like this in there too. 
It seems better than having per-library information smattered all over the code
base.

     if (compiler.jsIndexingBehaviorInterface !== null) {
       library.define(compiler.jsIndexingBehaviorInterface, compiler);
     }
   }
-
-  // Additionaly, if this is a test, we allow access to foreign functions.
-  if (library.script.name.contains('dart/tests/compiler/dart2js_native')) {
-    library.define(compiler.findHelper(const SourceString('JS')), compiler);
-  }
 }
 
 void checkAllowedLibrary(ElementListener listener, Token token) {
   LibraryElement currentLibrary = listener.compilationUnitElement.getLibrary();
   if (!currentLibrary.canUseNative) {
     listener.recoverableError("Unexpected token", token: token);
   }
 }
 
 Token handleNativeBlockToSkip(Listener listener, Token token) {
@@ skipping 230 matching lines @@
                                       String parameters) {
   buffer.add("  if (Object.getPrototypeOf(this).hasOwnProperty");
   buffer.add("('$methodName')) {\n");
   buffer.add("  $code");
   buffer.add("  } else {\n");
   buffer.add("    return Object.prototype.$methodName.call(this");
   buffer.add(parameters == '' ? '' : ', $parameters');
   buffer.add(");\n");
   buffer.add("  }\n");
 }