Make PyAuto functional tests compatible with python 2.7

Make PyAuto functional tests compatible with python 2.7

Previously a pyauto functional test tries to restart itself with a correct version of python(i.e. 2.6) if it finds out the current python version is not 2.6. 
Make changes to pyauto_functional.py so that it will check the value of an environment variable DO_NOT_RESTART_PYTHON_FOR_PYAUTO when the test starts.
If DO_NOT_RESTART_PYTHON_FOR_PYAUTO is set (to any value), it will not try to restart itself regardless what the current python version is.

This is to allow users to run PyAuto with python 2.7. Users of python 2.7 can now run PyAuto functional tests by setting this environment variable (to any value).

BUG=None
TEST=Ran test_basic.py with DO_NOT_RESTART_PYTHON_FOR_PYAUTO set and unset.
NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146284

[fdeng1, 2012-07-04 00:58:39]

Hi Dennis and Nirnimesh,

I've modified pyauto_functional.py to make it be able to run with python 2.7.

Please take a look and let me know any recommendations.

Fang

[dennis_jeffrey, 2012-07-04 01:04:18]

https://chromiumcodereview.appspot.com/10694077/diff/1/chrome/test/functional...
File chrome/test/functional/pyauto_functional.py (right):

https://chromiumcodereview.appspot.com/10694077/diff/1/chrome/test/functional...
chrome/test/functional/pyauto_functional.py:86:
RunWithCorrectPythonIfNecessary()
It might make more sense to add the check here.  We shouldn't even invoke this
function at all if the environment variable is set.

Additionally, maybe we can just check if the env variable exists (not None); no
need to force it to have value true.

[fdeng1, 2012-07-09 20:52:37]

Hi Craig,

Would you please take a look at this cl. I am trying to make pyauto functional
tests work with python 2.7. I modified pyauto_functional.py so that it will
check whether an environment DO_NOT_RESTART_PYTHON_FOR_PYAUTO has been set. If
so, it will not try to restart itself with the correct version of python and
print a message.(I am actually hesitating between "print" and "logging.debug". I
observed the around code use print so I use it too. Please let me know if the
other one is better.)

Thank you.
Fang

https://chromiumcodereview.appspot.com/10694077/diff/1/chrome/test/functional...
File chrome/test/functional/pyauto_functional.py (right):

https://chromiumcodereview.appspot.com/10694077/diff/1/chrome/test/functional...
chrome/test/functional/pyauto_functional.py:86:
RunWithCorrectPythonIfNecessary()
I've moved the check here.
On 2012/07/04 01:04:18, dennis_jeffrey wrote:
> It might make more sense to add the check here.  We shouldn't even invoke this
> function at all if the environment variable is set.
> 
> Additionally, maybe we can just check if the env variable exists (not None);
no
> need to force it to have value true.

[craigdh, 2012-07-09 21:13:15]

On 2012/07/09 20:52:37, fdeng1 wrote:
> Hi Craig,
> 
> Would you please take a look at this cl. I am trying to make pyauto functional
> tests work with python 2.7. I modified pyauto_functional.py so that it will
> check whether an environment DO_NOT_RESTART_PYTHON_FOR_PYAUTO has been set. If
> so, it will not try to restart itself with the correct version of python and
> print a message.(I am actually hesitating between "print" and "logging.debug".
I
> observed the around code use print so I use it too. Please let me know if the
> other one is better.)
> 
> Thank you.
> Fang
> 
>
https://chromiumcodereview.appspot.com/10694077/diff/1/chrome/test/functional...
> File chrome/test/functional/pyauto_functional.py (right):
> 
>
https://chromiumcodereview.appspot.com/10694077/diff/1/chrome/test/functional...
> chrome/test/functional/pyauto_functional.py:86:
> RunWithCorrectPythonIfNecessary()
> I've moved the check here.
> On 2012/07/04 01:04:18, dennis_jeffrey wrote:
> > It might make more sense to add the check here.  We shouldn't even invoke
this
> > function at all if the environment variable is set.
> > 
> > Additionally, maybe we can just check if the env variable exists (not None);
> no
> > need to force it to have value true.

lgtm, but you will need the go-ahead from a full committer before you can
commit.

[Nirnimesh, 2012-07-12 02:36:24]

LGTM.

Please add notes at http://dev.chromium.org/developers/testing/pyauto about
this, after committing.

https://chromiumcodereview.appspot.com/10694077/diff/7002/chrome/test/functio...
File chrome/test/functional/pyauto_functional.py (right):

https://chromiumcodereview.appspot.com/10694077/diff/7002/chrome/test/functio...
chrome/test/functional/pyauto_functional.py:80: # Check the environment variable
DO_NOT_RESTART_PYTHON_FOR_PYAUTO. If
The comment is too long, and is explaining the code. Change to:
Do not attempt to figure out python versions if DO_NOT_RESTART_PYTHON_FOR_PYAUTO
is set.

[commit-bot: I haz the power, 2012-07-12 03:46:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fdeng@chromium.org/10694077/15001

[commit-bot: I haz the power, 2012-07-12 03:47:04]

Change committed as 146284

[fdeng1, 2012-07-12 03:47:52]

Thanks Nirnimesh. I've addressed your comment.

https://chromiumcodereview.appspot.com/10694077/diff/7002/chrome/test/functio...
File chrome/test/functional/pyauto_functional.py (right):

https://chromiumcodereview.appspot.com/10694077/diff/7002/chrome/test/functio...
chrome/test/functional/pyauto_functional.py:80: # Check the environment variable
DO_NOT_RESTART_PYTHON_FOR_PYAUTO. If
On 2012/07/12 02:36:24, Nirnimesh wrote:
> The comment is too long, and is explaining the code. Change to:
> Do not attempt to figure out python versions if
DO_NOT_RESTART_PYTHON_FOR_PYAUTO
> is set.

Done.