Issue 10694069: Fix difference on behavior on python 2.6 on linux with open(mode='rU').

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10694069: Fix difference on behavior on python 2.6 on linux with open(mode='rU'). (Closed)

Created:
8 years, 5 months ago by M-A Ruel

Modified:
8 years, 5 months ago

Reviewers:
cmp

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Fix difference on behavior on python 2.6 on linux with open(mode='rU'). TBR=cmp@chromium.org BUG= TEST=manually tested gclient sync works on linux with python 2.6 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145315

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	gclient_utils.py	View		1 chunk	+5 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10694069/1

8 years, 5 months ago (2012-07-03 16:34:49 UTC) #2

cmp

8 years, 5 months ago (2012-07-10 01:22:09 UTC) #4

lgtm

This is scary because there are so many opportunities for it to go wrong.