Issue 10694063: Remove layout_test_helper from webkit/tools/test_shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10694063: Remove layout_test_helper from webkit/tools/test_shell. (Closed)

Created:
8 years, 5 months ago by tony

Modified:
8 years, 5 months ago

Reviewers:
tkent, jamesr, dglazkov1

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove layout_test_helper from webkit/tools/test_shell. This was used when we ran layout tests using test_shell, but is no longer needed. There's a ported copy in WebKit's repo. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145330

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -190 lines)			Patch
D	webkit/tools/test_shell/mac/layout_test_helper.mm	View	1 chunk	+0 lines, -87 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gypi	View	3 chunks	+0 lines, -41 lines	0 comments	Download
D	webkit/tools/test_shell/win/layout_test_helper.cc	View	1 chunk	+0 lines, -62 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10694063/1

8 years, 5 months ago (2012-07-03 16:51:49 UTC) #3

commit-bot: I haz the power

8 years, 5 months ago (2012-07-03 17:35:49 UTC) #4

Try job failure for 10694063-1 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages