Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: chrome/browser/bookmarks/bookmark_extension_helpers.h

Issue 10694062: Refactor chrome.bookmarks API to use JSON schema compiler. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Sync with trunk Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_extension_helpers.h
diff --git a/chrome/browser/bookmarks/bookmark_extension_helpers.h b/chrome/browser/bookmarks/bookmark_extension_helpers.h
index f4e8e2e2a0d558b9d6092eeb7846229c6a7112f0..7ffd3df985a3d6f53e26800d7dd30d23c05eb1b2 100644
--- a/chrome/browser/bookmarks/bookmark_extension_helpers.h
+++ b/chrome/browser/bookmarks/bookmark_extension_helpers.h
@@ -6,28 +6,49 @@
#define CHROME_BROWSER_BOOKMARKS_BOOKMARK_EXTENSION_HELPERS_H_
#include <string>
+#include <vector>
#include "base/basictypes.h"
+#include "chrome/common/extensions/api/bookmarks.h"
class BookmarkModel;
class BookmarkNode;
-namespace base {
-class DictionaryValue;
-class ListValue;
-}
-
// Helper functions.
namespace bookmark_extension_helpers {
// The returned value is owned by the caller.
+extensions::api::bookmarks::BookmarkTreeNode* GetBookmarkTreeNode(
+ const BookmarkNode* node,
+ bool recurse,
+ bool only_folders);
+
+// TODO(mwrosen): Remove this function once chrome.experimental.bookmarkManager
+// is refactored to use the JSON schema compiler.
base::DictionaryValue* GetNodeDictionary(const BookmarkNode* node,
bool recurse,
bool only_folders);
-// Add a JSON representation of |node| to the JSON |list|.
-void AddNode(const BookmarkNode* node, base::ListValue* list, bool recurse);
+// Add a JSON representation of |node| to the JSON |nodes|.
+void AddNode(const BookmarkNode* node,
+ std::vector<linked_ptr<
+ extensions::api::bookmarks::BookmarkTreeNode> >* nodes,
+ bool recurse);
+
+void AddNodeFoldersOnly(const BookmarkNode* node,
+ std::vector<linked_ptr<
+ extensions::api::bookmarks::BookmarkTreeNode> >*
+ nodes,
+ bool recurse);
+
+// TODO(mwrosen): Remove this function once chrome.experimental.bookmarkManager
+// is refactored to use the JSON schema compiler.
+void AddNode(const BookmarkNode* node,
+ base::ListValue* list,
+ bool recurse);
+// TODO(mwrosen): Remove this function once chrome.experimental.bookmarkManager
+// is refactored to use the JSON schema compiler.
void AddNodeFoldersOnly(const BookmarkNode* node,
base::ListValue* list,
bool recurse);

Powered by Google App Engine
This is Rietveld 408576698