chrome/browser/extensions/app_notification_manager.cc - Issue 10694056: CPM Extension Uninstall Watching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/app_notification_manager.cc

Issue 10694056: CPM Extension Uninstall Watching (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Requested changes made Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/app_notification_manager.cc

diff --git a/chrome/browser/extensions/app_notification_manager.cc b/chrome/browser/extensions/app_notification_manager.cc

index 6b1566af8879098a925e3a4ab6cbb7e52ec1c07c..e1fd6aa53d804d79d2c14839bea460f8ccc67bd5 100644

--- a/chrome/browser/extensions/app_notification_manager.cc

+++ b/chrome/browser/extensions/app_notification_manager.cc

@@ -175,7 +175,7 @@ void AppNotificationManager::Observe(

const content::NotificationSource& source,

const content::NotificationDetails& details) {

CHECK(type == chrome::NOTIFICATION_EXTENSION_UNINSTALLED);

- ClearAll(*content::Details<const std::string>(details).ptr());

+ ClearAll(content::Details<const extensions::Extension>(details).ptr()->id());

}

syncer::SyncDataList AppNotificationManager::GetAllSyncData(