chrome/browser/automation/automation_provider_observers.cc - Issue 10694056: CPM Extension Uninstall Watching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/automation_provider_observers.cc

Issue 10694056: CPM Extension Uninstall Watching (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Requested changes made Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/automation/automation_provider_observers.cc

diff --git a/chrome/browser/automation/automation_provider_observers.cc b/chrome/browser/automation/automation_provider_observers.cc

index 5ea90fce8f906c69b29e89c919c9cddf272999d3..52a2b9411e605d137b1e5ed22ba260cba94ca443 100644

--- a/chrome/browser/automation/automation_provider_observers.cc

+++ b/chrome/browser/automation/automation_provider_observers.cc

@@ -544,7 +544,7 @@ void ExtensionUninstallObserver::Observe(

switch (type) {

case chrome::NOTIFICATION_EXTENSION_UNINSTALLED: {

- if (id_ == *content::Details<const std::string>(details).ptr()) {

+ if (id_ == content::Details<extensions::Extension>(details).ptr()->id()) {

scoped_ptr<DictionaryValue> return_value(new DictionaryValue);

return_value->SetBoolean("success", true);

AutomationJSONReply(automation_, reply_message_.release())