Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3420)

Unified Diff: build/android/buildbot_functions.sh

Issue 10694048: Refactor and rename install-build-deps-android-sdk (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/buildbot_fyi.sh » ('j') | build/install-android-sdk-ndk.sh » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot_functions.sh
diff --git a/build/android/buildbot_functions.sh b/build/android/buildbot_functions.sh
index dcea5f520064789c72e70fbe5a9576032f4e577e..5d39b62f12969aa88245ba1dd28ea1e0773e3821 100755
--- a/build/android/buildbot_functions.sh
+++ b/build/android/buildbot_functions.sh
@@ -43,20 +43,6 @@ function bb_setup_environment {
export ANDROID_NDK_ROOT=/usr/local/google/android-ndk-r7
}
-# Install the build deps by running
-# build/install-build-deps-android-sdk.sh. This may update local tools.
-# $1: source root.
-function bb_install_build_deps {
- echo "@@@BUILD_STEP install build deps android@@@"
- local script="$1/build/install-build-deps-android-sdk.sh"
- if [[ -f "$script" ]]; then
- "$script"
- else
- echo "@@@STEP_WARNINGS@@@"
- echo "Cannot find $script; why?"
- fi
-}
-
# Function to force-green a bot.
function bb_force_bot_green_and_exit {
echo "@@@BUILD_STEP Bot forced green.@@@"
@@ -105,10 +91,8 @@ function bb_baseline_setup {
NEED_CLOBBER=1
fi
- # Setting up a new bot? Must do this before envsetup.sh
- if [ ! -d "${ANDROID_NDK_ROOT}" ] ; then
- bb_install_build_deps $SRC_ROOT
- fi
+ # Install sdk and ndk if necessary
+ "$SRC_ROOT/build/install-android-sdk-ndk.sh" --auto
echo "@@@BUILD_STEP Configure with envsetup.sh@@@"
. build/android/envsetup.sh
« no previous file with comments | « no previous file | build/android/buildbot_fyi.sh » ('j') | build/install-android-sdk-ndk.sh » ('J')

Powered by Google App Engine
This is Rietveld 408576698