Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 10694036: Allow to build 10.6 binaries on Darwin x86_64 (the following binaries were actually built on such). (Closed)

Created:
8 years, 5 months ago by Alexander Potapenko
Modified:
8 years, 5 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, Brad Chen (chromium), kcc2
Visibility:
Public.

Description

Allow to build 10.6 binaries on Darwin x86_64 (the following binaries were actually built on such). Roll the newer (r4383) TSan binaries for Mac OS 10.6 which reports less errors than the previous one (r2939) locally. Because we didn't track the TSan versions before, I've set them to unknown for all the platforms. BUG=120136 TBR=timurrrr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144905

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M README.chromium View 1 chunk +4 lines, -2 lines 0 comments Download
M binaries/mac_10.6/bin/valgrind-tsan.sh View Binary file 0 comments Download
M scripts/build-tsan-for-chromium.sh View 1 chunk +1 line, -1 line 1 comment Download
M scripts/common.sh View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexander Potapenko
TBR
8 years, 5 months ago (2012-06-29 13:05:10 UTC) #1
Timur Iskhodzhanov
https://chromiumcodereview.appspot.com/10694036/diff/1/scripts/build-tsan-for-chromium.sh File scripts/build-tsan-for-chromium.sh (right): https://chromiumcodereview.appspot.com/10694036/diff/1/scripts/build-tsan-for-chromium.sh#newcode73 scripts/build-tsan-for-chromium.sh:73: TSAN_REV=4383 Hm, I'd expect you to update the Linux&Windows ...
8 years, 5 months ago (2012-07-05 11:05:00 UTC) #2
Alexander Potapenko
Sorry, I didn't have time to test the Linux binaries, and I don't have an ...
8 years, 5 months ago (2012-07-06 08:05:17 UTC) #3
Timur Iskhodzhanov
8 years, 5 months ago (2012-07-06 09:08:59 UTC) #4
On Fri, Jul 6, 2012 at 12:05 PM, Alexander Potapenko
<glider@chromium.org> wrote:
> Sorry, I didn't have time to test the Linux binaries, and I don't have
> an idea how to do that on Windows.
Windows: usually one should just copy the binaries from the buildbot.
Yes, it's down now :(

> I also don't think they'll benefit from the update much.
Yes.
I just don't like having
a) different revisions on different platforms
b) one binaries checked in and different binaries you'd get if you
re-run the script (usually those should have the same rev)

> On Thu, Jul 5, 2012 at 3:05 PM,  <timurrrr@chromium.org> wrote:
>>
>>
https://chromiumcodereview.appspot.com/10694036/diff/1/scripts/build-tsan-for...
>> File scripts/build-tsan-for-chromium.sh (right):
>>
>>
https://chromiumcodereview.appspot.com/10694036/diff/1/scripts/build-tsan-for...
>> scripts/build-tsan-for-chromium.sh:73: TSAN_REV=4383
>> Hm, I'd expect you to update the Linux&Windows binaries to this revision
>> too.
>>
>> https://chromiumcodereview.appspot.com/10694036/
>
>
>
> --
> Alexander Potapenko
> Software Engineer
> Google Moscow

Powered by Google App Engine
This is Rietveld 408576698