Only call IsValidRevision() when it is a git hash.

Only call IsValidRevision() when it is a git hash.

Calling IsValidRevision('refs/head/master') will always return True.

TBR=bauerb@chromium.org
BUG=134858
TEST=Tested manually with 'managed': True


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144786

[commit-bot: I haz the power, 2012-06-28 19:51:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10694022/1

[commit-bot: I haz the power, 2012-06-28 19:55:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10694022/1

[commit-bot: I haz the power, 2012-06-28 19:58:45]

Change committed as 144786

[Bernhard Bauer, 2012-06-28 22:59:18]

The description doesn't seem to match what the CL does; I think the CL doesn't
change the behavior of IsValidRevision, it just only calls it for hash-like
revisions?

Is this to support DEPS files that always use HEAD and therefore always require
a `git fetch`?

[M-A Ruel, 2012-06-28 23:06:17]

On 2012/06/28 22:59:18, Bernhard Bauer wrote:
> The description doesn't seem to match what the CL does; I think the CL doesn't
> change the behavior of IsValidRevision, it just only calls it for hash-like
> revisions?

The CL description is what the code does. IsValidRevision is only called for
hash-like revisions.

> Is this to support DEPS files that always use HEAD and therefore always
require
> a `git fetch`?

No, it's for managed checkout. See the bug.

[Bernhard Bauer, 2012-06-28 23:12:43]

Ok, I'm stupid. LGTM :)