Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7677)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 10694018: [Mac] Do not show the fullscreen exit bubble while transitioning. Wait until the transition ends. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
index 3de70af6fafa78562686ac2d2acd1632131ff39e..6f969b0f02752b28db2cdaa3641819ae137c984a 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
@@ -796,6 +796,14 @@ willPositionSheet:(NSWindow*)sheet
}
- (void)showFullscreenExitBubbleIfNecessary {
+ // This method is called in response to
+ // |-updateFullscreenExitBubbleURL:bubbleType:|. If on Lion the system is
+ // transitioning, do not show the bubble because it will cause visual jank
+ // <http://crbug.com/130649>. This will be called again as part of
+ // |-windowDidEnterFullScreen:|, so arrange to do that work then instead.
+ if (enteringFullscreen_)
+ return;
+
[presentationModeController_ ensureOverlayHiddenWithAnimation:NO delay:NO];
if (fullscreenBubbleType_ == FEB_TYPE_NONE ||
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698