Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: ui/views/controls/textfield/native_textfield_views.cc

Issue 10693160: Add and specify Views::Textfield::SelectAll |reversed| flag, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove redundant comments. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/textfield/native_textfield_views.cc
diff --git a/ui/views/controls/textfield/native_textfield_views.cc b/ui/views/controls/textfield/native_textfield_views.cc
index 80e785a720e4cf58d37ec13b6046f07933c15888..beb1437e2983ec78c7b5935590cc3f6e187f7938 100644
--- a/ui/views/controls/textfield/native_textfield_views.cc
+++ b/ui/views/controls/textfield/native_textfield_views.cc
@@ -159,7 +159,7 @@ ui::GestureStatus NativeTextfieldViews::OnGestureEvent(
OnAfterUserAction();
return ui::GESTURE_STATUS_CONSUMED;
case ui::ET_GESTURE_DOUBLE_TAP:
- SelectAll();
+ SelectAll(false);
return ui::GESTURE_STATUS_CONSUMED;
case ui::ET_GESTURE_SCROLL_UPDATE:
OnBeforeUserAction();
@@ -370,9 +370,9 @@ string16 NativeTextfieldViews::GetSelectedText() const {
return model_->GetSelectedText();
}
-void NativeTextfieldViews::SelectAll() {
+void NativeTextfieldViews::SelectAll(bool reversed) {
OnBeforeUserAction();
- model_->SelectAll();
+ model_->SelectAll(reversed);
OnCaretBoundsChanged();
SchedulePaint();
OnAfterUserAction();
@@ -618,7 +618,7 @@ void NativeTextfieldViews::ExecuteCommand(int command_id) {
text_changed = model_->Delete();
break;
case IDS_APP_SELECT_ALL:
- SelectAll();
+ SelectAll(false);
break;
default:
textfield_->GetController()->ExecuteCommand(command_id);
@@ -927,7 +927,7 @@ bool NativeTextfieldViews::HandleKeyEvent(const KeyEvent& key_event) {
break;
case ui::VKEY_A:
if (control) {
- model_->SelectAll();
+ model_->SelectAll(false);
cursor_changed = true;
}
break;
@@ -1177,7 +1177,7 @@ void NativeTextfieldViews::HandleMousePressEvent(const MouseEvent& event) {
OnCaretBoundsChanged();
break;
case 2:
- model_->SelectAll();
+ model_->SelectAll(false);
OnCaretBoundsChanged();
break;
default:
« no previous file with comments | « ui/views/controls/textfield/native_textfield_views.h ('k') | ui/views/controls/textfield/native_textfield_views_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698