chrome/browser/ui/views/omnibox/omnibox_view_views.cc - Issue 10693160: Add and specify Views::Textfield::SelectAll |reversed| flag, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 10693160: Add and specify Views::Textfield::SelectAll |reversed| flag, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove redundant comments. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

index 9b810c5e145d773b477341b6fddb2d3209b54a84..1d5595b715d7f33335a70785ee7dc3d185bff3e9 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

@@ -614,10 +614,7 @@ void OmniboxViewViews::GetSelectionBounds(string16::size_type* start,

}

void OmniboxViewViews::SelectAll(bool reversed) {

- if (reversed)

- textfield_->SelectRange(ui::Range(GetTextLength(), 0));

- else

- textfield_->SelectRange(ui::Range(0, GetTextLength()));

+ textfield_->SelectAll(reversed);

}

void OmniboxViewViews::RevertAll() {

« no previous file with comments | « chrome/browser/ui/views/login_view.cc ('k') | ui/gfx/render_text.h » ('j') | no next file with comments »