Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: chrome/browser/ui/views/find_bar_view.cc

Issue 10693160: Add and specify Views::Textfield::SelectAll |reversed| flag, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove redundant comments. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/edit_search_engine_dialog.cc ('k') | chrome/browser/ui/views/login_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/find_bar_view.cc
diff --git a/chrome/browser/ui/views/find_bar_view.cc b/chrome/browser/ui/views/find_bar_view.cc
index f113822345e5583db0f058f30dc923401e75785e..25dce062181548696471eefa854cd97884357804 100644
--- a/chrome/browser/ui/views/find_bar_view.cc
+++ b/chrome/browser/ui/views/find_bar_view.cc
@@ -186,7 +186,7 @@ void FindBarView::UpdateForResult(const FindNotificationDetails& result,
// update the text only when the IME is not composing text.
if (find_text_->text() != find_text && !find_text_->IsIMEComposing()) {
find_text_->SetText(find_text);
- find_text_->SelectAll();
+ find_text_->SelectAll(true);
}
if (find_text.empty() || !have_valid_range) {
@@ -220,7 +220,7 @@ void FindBarView::ClearMatchCount() {
void FindBarView::SetFocusAndSelection(bool select_all) {
find_text_->RequestFocus();
if (select_all && !find_text_->text().empty())
- find_text_->SelectAll();
+ find_text_->SelectAll(true);
}
///////////////////////////////////////////////////////////////////////////////
@@ -478,7 +478,7 @@ void FindBarView::SearchTextfieldView::RequestFocus() {
if (HasFocus())
return;
views::View::RequestFocus();
- SelectAll();
+ SelectAll(true);
}
FindBarHost* FindBarView::find_bar_host() const {
« no previous file with comments | « chrome/browser/ui/views/edit_search_engine_dialog.cc ('k') | chrome/browser/ui/views/login_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698