Add pak file support for content shell and android apks.

Add pak file support for content shell and android apks.

.pak files are stored in the apk and need to be extracted to the file system
for them to be accessible by the native side.  The ResourceExtractor handles
asynchronously moving the .pak files from the apk to the local data directory
of the running application.

BUG=136752
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146465

[Ted C, 2012-07-11 23:35:17]

yfriedman & jcivelli - EVERYTHING!!!!
jam - content/shell && content_shell.gypi OWNERS

[Yaron, 2012-07-12 01:00:59]

http://codereview.chromium.org/10693157/diff/2001/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java
(right):

http://codereview.chromium.org/10693157/diff/2001/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java:29:
* Handles extracting the necessary resources bundled in the Chrome APK and
moving them to a
This isn't specific to chrome anymore.

http://codereview.chromium.org/10693157/diff/2001/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java:91:
// so that we unpack the correct .pak file (see http://b/6504501).
Please file crbug

http://codereview.chromium.org/10693157/diff/2001/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java:97:
// Uncomment these lines to support Yiddish:
??? Probably should remove this..

http://codereview.chromium.org/10693157/diff/2001/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java:281:
return new File(context.getDir("chrome", Context.MODE_PRIVATE), "paks");
Hmm. This shouldn't mention chrome.

http://codereview.chromium.org/10693157/diff/2001/content/shell/android/shell...
File content/shell/android/shell_descriptors.h (left):

http://codereview.chromium.org/10693157/diff/2001/content/shell/android/shell...
content/shell/android/shell_descriptors.h:7: #pragma once
Add #pragma once

http://codereview.chromium.org/10693157/diff/2001/content/shell/shell_content...
File content/shell/shell_content_browser_client.h (right):

http://codereview.chromium.org/10693157/diff/2001/content/shell/shell_content...
content/shell/shell_content_browser_client.h:37: virtual void
GetAdditionalMappedFilesForChildProcess(
Nit: indentation is off

[Ted C, 2012-07-12 01:20:18]

http://codereview.chromium.org/10693157/diff/2001/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java
(right):

http://codereview.chromium.org/10693157/diff/2001/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java:29:
* Handles extracting the necessary resources bundled in the Chrome APK and
moving them to a
On 2012/07/12 01:00:59, Yaron wrote:
> This isn't specific to chrome anymore.

Done.

http://codereview.chromium.org/10693157/diff/2001/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java:91:
// so that we unpack the correct .pak file (see http://b/6504501).
On 2012/07/12 01:00:59, Yaron wrote:
> Please file crbug

Done.

http://codereview.chromium.org/10693157/diff/2001/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java:97:
// Uncomment these lines to support Yiddish:
On 2012/07/12 01:00:59, Yaron wrote:
> ??? Probably should remove this..

Done.

http://codereview.chromium.org/10693157/diff/2001/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java:281:
return new File(context.getDir("chrome", Context.MODE_PRIVATE), "paks");
On 2012/07/12 01:00:59, Yaron wrote:
> Hmm. This shouldn't mention chrome.

This needs to match the value in PathUtils.java.  Granted, that also has a TODO
to fix that.  I can do that in this CL or in a follow up.

http://codereview.chromium.org/10693157/diff/2001/content/shell/android/shell...
File content/shell/android/shell_descriptors.h (left):

http://codereview.chromium.org/10693157/diff/2001/content/shell/android/shell...
content/shell/android/shell_descriptors.h:7: #pragma once
On 2012/07/12 01:00:59, Yaron wrote:
> Add #pragma once

I think they are removing all these from content.  See:
https://chromiumcodereview.appspot.com/10696166

http://codereview.chromium.org/10693157/diff/2001/content/shell/shell_content...
File content/shell/shell_content_browser_client.h (right):

http://codereview.chromium.org/10693157/diff/2001/content/shell/shell_content...
content/shell/shell_content_browser_client.h:37: virtual void
GetAdditionalMappedFilesForChildProcess(
On 2012/07/12 01:00:59, Yaron wrote:
> Nit: indentation is off

Done.

[Yaron, 2012-07-12 01:32:17]

lgtm

http://codereview.chromium.org/10693157/diff/2001/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java
(right):

http://codereview.chromium.org/10693157/diff/2001/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java:281:
return new File(context.getDir("chrome", Context.MODE_PRIVATE), "paks");
On 2012/07/12 01:20:18, Ted C wrote:
> On 2012/07/12 01:00:59, Yaron wrote:
> > Hmm. This shouldn't mention chrome.
> 
> This needs to match the value in PathUtils.java.  Granted, that also has a
TODO
> to fix that.  I can do that in this CL or in a follow up.

Follow up sgtm

[jochen (gone - plz use gerrit), 2012-07-12 09:22:07]

content/ looks good. I don't know enough about the java side to review that part

http://codereview.chromium.org/10693157/diff/1010/content/shell/android/shell...
File content/shell/android/shell_descriptors.h (right):

http://codereview.chromium.org/10693157/diff/1010/content/shell/android/shell...
content/shell/android/shell_descriptors.h:11: kShellPakDescriptor = 1
nit. please keep the , at the end

[Ted C, 2012-07-12 17:01:26]

http://codereview.chromium.org/10693157/diff/1010/content/shell/android/shell...
File content/shell/android/shell_descriptors.h (right):

http://codereview.chromium.org/10693157/diff/1010/content/shell/android/shell...
content/shell/android/shell_descriptors.h:11: kShellPakDescriptor = 1
On 2012/07/12 09:22:07, jochen wrote:
> nit. please keep the , at the end

Done.

[Jay Civelli, 2012-07-12 17:27:11]

http://codereview.chromium.org/10693157/diff/1010/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java
(right):

http://codereview.chromium.org/10693157/diff/1010/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java:50:
+ "beginning the resource extrations";
Typo: extraction

http://codereview.chromium.org/10693157/diff/1010/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java:89:
// Android uses non-standard language codes for Indonesian, Hebrew, and Yiddish:
You say 3 languages but I see only 2 below.

http://codereview.chromium.org/10693157/diff/1010/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java:250:
// Don't leave the files in a inconsistent state.
Nit: a -> an

http://codereview.chromium.org/10693157/diff/1010/content/shell/android/shell...
File content/shell/android/shell_descriptors.h (right):

http://codereview.chromium.org/10693157/diff/1010/content/shell/android/shell...
content/shell/android/shell_descriptors.h:11: kShellPakDescriptor = 1
On 2012/07/12 09:22:07, jochen wrote:
> nit. please keep the , at the end
 In content/public/common_descriptor.h there is a constant at which embedders
should start for their descriptors.

[Ted C, 2012-07-12 18:14:47]

http://codereview.chromium.org/10693157/diff/1010/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java
(right):

http://codereview.chromium.org/10693157/diff/1010/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java:50:
+ "beginning the resource extrations";
On 2012/07/12 17:27:11, Jay Civelli wrote:
> Typo: extraction

Done.

http://codereview.chromium.org/10693157/diff/1010/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java:89:
// Android uses non-standard language codes for Indonesian, Hebrew, and Yiddish:
On 2012/07/12 17:27:11, Jay Civelli wrote:
> You say 3 languages but I see only 2 below.

It was originally commented out (and removed as part of a previous review
comment), but there is no reason not to add it here for if/when we support
Yiddish.  I'll add it here uncommented.

http://codereview.chromium.org/10693157/diff/1010/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java:250:
// Don't leave the files in a inconsistent state.
On 2012/07/12 17:27:11, Jay Civelli wrote:
> Nit: a -> an

Done.

http://codereview.chromium.org/10693157/diff/1010/content/shell/android/shell...
File content/shell/android/shell_descriptors.h (right):

http://codereview.chromium.org/10693157/diff/1010/content/shell/android/shell...
content/shell/android/shell_descriptors.h:11: kShellPakDescriptor = 1
On 2012/07/12 17:27:11, Jay Civelli wrote:
> On 2012/07/12 09:22:07, jochen wrote:
> > nit. please keep the , at the end
>  In content/public/common_descriptor.h there is a constant at which embedders
> should start for their descriptors.

That file hasn't yet been upstreamed, so let's do that refactoring in a follow
up.

[Jay Civelli, 2012-07-12 18:18:08]

lgtm

[jam, 2012-07-12 18:57:21]

lgtm

[commit-bot: I haz the power, 2012-07-12 21:03:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedchoc@chromium.org/10693157/9007

[commit-bot: I haz the power, 2012-07-12 22:15:06]

Change committed as 146465