Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10693139: Remove #pragma once from chrome/browser/{tab_contents,password_manager,profiles,search_engines,noti… (Closed)

Created:
8 years, 5 months ago by awong
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove #pragma once from chrome/browser/{tab_contents,password_manager,profiles,search_engines,notifications} For context: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -88 lines) Patch
M chrome/browser/notifications/balloon.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/balloon_collection.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/balloon_collection_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/balloon_collection_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/balloon_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_object_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_options_menu_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_prefs_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_test_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_ui_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_ui_manager_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_ui_manager_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/encryptor.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/encryptor_password_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/ie7_password.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/login_database.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_form_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_form_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager_delegate_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_change.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_consumer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_default.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_mac_internal.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_x.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/chrome_version_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/gaia_info_update_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_destroyer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_downloader.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_downloader_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_info_cache.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_info_cache_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_info_cache_unittest.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_info_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/search_engine_type.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/search_host_to_urls_map.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/search_provider_install_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/search_terms_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_fetcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_fetcher_callbacks.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_fetcher_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_id.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/util.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/background_contents.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/confirm_infobar_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/insecure_content_infobar_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/language_state.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/link_infobar_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_browsertest_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/retargeting_details.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/simple_alert_infobar_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/spellchecker_submenu_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/spelling_bubble_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/spelling_menu_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_ssl_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_win.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
awong
avi: tab_contents isherman: password_manager erg: profiles sky: search_engines stevenjb: notifications
8 years, 5 months ago (2012-07-11 02:10:29 UTC) #1
Ilya Sherman
lgtm
8 years, 5 months ago (2012-07-11 04:46:03 UTC) #2
stevenjb
lgtm Can we assign this to an issue # with reference to the discussion on ...
8 years, 5 months ago (2012-07-11 15:38:57 UTC) #3
Elliot Glaysher
profiles lgtm
8 years, 5 months ago (2012-07-11 16:26:28 UTC) #4
sky
LGTM
8 years, 5 months ago (2012-07-16 22:01:38 UTC) #5
Avi (use Gerrit)
8 years, 5 months ago (2012-07-17 14:33:24 UTC) #6 
On 2012/07/16 22:01:38, sky wrote:
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld 408576698