Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 10693138: Remove #pragma once from chrome/service (Closed)

Created:
8 years, 5 months ago by awong
Modified:
8 years, 5 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews
Visibility:
Public.

Description

Remove #pragma once from chrome/service Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M chrome/service/chrome_service_application_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_auth.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_connector.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_consts.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_helpers.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_token_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_wipeout.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/cloud_print/job_status_updater.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/cloud_print/print_system.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/cloud_print/printer_job_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/gaia/service_gaia_authenticator.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/net/service_url_request_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/service_process.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/service_process_prefs.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/service_utility_process_host.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
awong
8 years, 5 months ago (2012-07-11 01:30:06 UTC) #1
Alpha Left Google
On 2012/07/11 01:30:06, awong wrote: I'm not familiar with these files, gene@ would be the ...
8 years, 5 months ago (2012-07-11 01:43:26 UTC) #2
awong
Actually, it doesn't matter. I'm just removing pragma onces. If you can verify that I ...
8 years, 5 months ago (2012-07-11 01:44:53 UTC) #3
Alpha Left Google
LGTM assuming it builds just fine.
8 years, 5 months ago (2012-07-11 02:00:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajwong@chromium.org/10693138/1
8 years, 5 months ago (2012-07-11 05:27:06 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 07:05:04 UTC) #6
Change committed as 146073

Powered by Google App Engine
This is Rietveld 408576698