Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 10693132: Merge 143306 - Rely on losing focus, not on becoming unfullscreened, to destroy a fullscreen window. (Closed)

Created:
8 years, 5 months ago by do not use1
Modified:
8 years, 5 months ago
Reviewers:
jbauman
CC:
chromium-reviews, yusukes+watch_chromium.org, jochen+watch-content_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Merge 143306 - Rely on losing focus, not on becoming unfullscreened, to destroy a fullscreen window. On metacity we get spurious unfullscreen events that were preventing the window from going fullscreen, and alt-tab didn't cause the window to unfullscreen, so it wasn't destroyed by alt-tab. We should ignore the unfullscreen event and instead rely on FocusOut to determine when to destroy the window. BUG=117021 TEST= Review URL: https://chromiumcodereview.appspot.com/10542134 TBR=jbauman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145973

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M content/browser/renderer_host/render_widget_host_view_gtk.h View 5 chunks +10 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 7 chunks +18 lines, -22 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
do not use1
8 years, 5 months ago (2012-07-10 22:48:00 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698