Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 10693128: chromeos: Show pending state for app update only. (Closed)

Created:
8 years, 5 months ago by xiyuan
Modified:
8 years, 5 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

chromeos: Show pending state for app update only. BUG=135673 TEST=Disable a pinned app either from extension settings page or admin policy and app should automatically unpinned from launcher instead of pulsing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146139

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xiyuan
8 years, 5 months ago (2012-07-10 16:27:41 UTC) #1
Mattias Nissler (ping if slow)
LGTM, but I'm not in OWNERS, adding Scott.
8 years, 5 months ago (2012-07-11 09:33:41 UTC) #2
xiyuan
Ben, could you stamp on the CL?
8 years, 5 months ago (2012-07-11 16:11:08 UTC) #3
Ben Goodger (Google)
lgtm
8 years, 5 months ago (2012-07-11 16:13:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10693128/1
8 years, 5 months ago (2012-07-11 16:15:55 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 17:48:11 UTC) #6
Change committed as 146139

Powered by Google App Engine
This is Rietveld 408576698