Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 10693114: Add iOS to the variations study proto. (Closed)

Created:
8 years, 5 months ago by SteveT
Modified:
8 years, 5 months ago
CC:
chromium-reviews, MAD, Ilya Sherman, jar (doing other things)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add iOS to the variations study proto. BUG=136181 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145618

Patch Set 1 #

Patch Set 2 : Add ios to variation_service conversion func. #

Patch Set 3 : update unit test #

Patch Set 4 : merge to tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M chrome/browser/metrics/proto/study.proto View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/metrics/variations_service.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/metrics/variations_service_unittest.cc View 1 2 3 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
SteveT
PTAL.
8 years, 5 months ago (2012-07-06 16:55:17 UTC) #1
Alexei Svitkine (slow)
Can you make a crbug for these changes? We'll also eventually want to add an ...
8 years, 5 months ago (2012-07-06 16:56:57 UTC) #2
Alexei Svitkine (slow)
On 2012/07/06 16:56:57, Alexei Svitkine wrote: > Can you make a crbug for these changes? ...
8 years, 5 months ago (2012-07-06 16:57:44 UTC) #3
SteveT
Okay! Over to you for another look.
8 years, 5 months ago (2012-07-06 17:06:17 UTC) #4
Alexei Svitkine (slow)
LGTM
8 years, 5 months ago (2012-07-06 17:06:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/10693114/6003
8 years, 5 months ago (2012-07-06 17:41:07 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/browser/metrics/variations_service.cc: While running patch -p1 --forward --force; patching file chrome/browser/metrics/variations_service.cc ...
8 years, 5 months ago (2012-07-06 18:58:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/10693114/6004
8 years, 5 months ago (2012-07-06 20:12:07 UTC) #8
commit-bot: I haz the power
8 years, 5 months ago (2012-07-06 22:27:34 UTC) #9
Change committed as 145618

Powered by Google App Engine
This is Rietveld 408576698