src/string.js - Issue 10693101: Only escape U+0022 in argument values of HTML extensions to String.prototype

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/string.js

Issue 10693101: Only escape U+0022 in argument values of HTML extensions to String.prototype (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/string.js

diff --git a/src/string.js b/src/string.js

index 6115930b6c8ff69568f425b8b996a821bc93cb87..eaeb198dce85366d5e3759ec4a649fe586f85991 100644

--- a/src/string.js

+++ b/src/string.js

@@ -825,10 +825,7 @@ function StringFromCharCode(code) {

// Helper function for very basic XSS protection.

function HtmlEscape(str) {

- return TO_STRING_INLINE(str).replace(/</g, "<")

- .replace(/>/g, ">")

- .replace(/"/g, """)

- .replace(/'/g, "'");

+ return TO_STRING_INLINE(str).replace(/"/g, """);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »