Don't miss error message in 'restart frame' debug action

Don't miss error message in 'restart frame' debug action

Committed: https://code.google.com/p/v8/source/detail?r=12074

[Yang, 2012-07-05 08:51:16]

LGTM with comment.

http://codereview.chromium.org/10693095/diff/1/src/liveedit.cc
File src/liveedit.cc (right):

http://codereview.chromium.org/10693095/diff/1/src/liveedit.cc#newcode1834
src/liveedit.cc:1834: return NULL;
Could be shorter:

if (result == NULL &&
    target.saved_status() == [etc.]) {
  return [error message];
}
return result;

[Peter Rybin, 2012-07-13 09:00:37]

On 2012/07/05 08:51:16, Yang wrote:
> LGTM with comment.
> 
> http://codereview.chromium.org/10693095/diff/1/src/liveedit.cc
> File src/liveedit.cc (right):
> 
> http://codereview.chromium.org/10693095/diff/1/src/liveedit.cc#newcode1834
> src/liveedit.cc:1834: return NULL;
> Could be shorter:
> 
> if (result == NULL &&
>     target.saved_status() == [etc.]) {
>   return [error message];
> }
> return result;

Yes. Thanks you. But the first return is sort of a formal construction --
"rethrowing" error code. I'd like to keep it this way even for the price of
couple of lines.