Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: vm/ast.cc

Issue 10693092: Remove unused code for StringConcatNode from the AST and the graph builder. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/ast.h ('k') | vm/ast_printer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/ast.cc
===================================================================
--- vm/ast.cc (revision 9395)
+++ vm/ast.cc (working copy)
@@ -183,18 +183,6 @@
}
-const Instance* StringConcatNode::EvalConstExpr() const {
- for (int i = 0; i < values()->length(); i++) {
- if (!values()->ElementAt(i)->IsLiteralNode()) {
- return NULL;
- }
- }
- // All nodes are literals, so this is a compile time constant string.
- // We just return the first literal as value approximation.
- return &values()->ElementAt(0)->AsLiteralNode()->literal();
-}
-
-
const Instance* BinaryOpNode::EvalConstExpr() const {
const Instance* left_val = this->left()->EvalConstExpr();
if (left_val == NULL) {
« no previous file with comments | « vm/ast.h ('k') | vm/ast_printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698