Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 10693088: Get URL and title at the beginning of favicon drag-and-drop, not at the end. (Closed)

Created:
8 years, 5 months ago by kinaba
Modified:
8 years, 5 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

Get URL and title at the beginning of favicon drag-and-drop, not at the end. Otherwise wrong URL is pasted when the active tab is changed during the drag and drop, and it neither matches the behavior of Chrome on other platforms (Win, Mac, Aura). BUG=94720, 103223 TEST=manually tested the following steps: 1) Open two tabs in a same window, with different URLs (say, a.com and b.org). 2) Start dragging the icon in the location bar of a.com tab. 3) While dragging, stay a while on b.org tab, and activate the tab. 4) Drop the URL to an empty space of the tab bar -> verify a.com is opened. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145820

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M chrome/browser/ui/gtk/location_bar_view_gtk.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinaba
Evan, could you have a look?
8 years, 5 months ago (2012-07-04 07:22:40 UTC) #1
Evan Stade
lgtm
8 years, 5 months ago (2012-07-09 20:20:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/10693088/2001
8 years, 5 months ago (2012-07-10 00:17:50 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-10 01:40:04 UTC) #4
Change committed as 145820

Powered by Google App Engine
This is Rietveld 408576698