Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4394)

Unified Diff: chrome/browser/chromeos/login/screen_locker.cc

Issue 10693087: chromeos: Request screen lock directly from session manager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove locking-related metrics code Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/screen_locker.cc
diff --git a/chrome/browser/chromeos/login/screen_locker.cc b/chrome/browser/chromeos/login/screen_locker.cc
index 25c2381783a4f5f3baf39d2773fa45c145cbc101..9394d0d773b7c3d1902221ab17763cd8779fb51c 100644
--- a/chrome/browser/chromeos/login/screen_locker.cc
+++ b/chrome/browser/chromeos/login/screen_locker.cc
@@ -49,7 +49,7 @@ using content::UserMetricsAction;
namespace {
// Observer to start ScreenLocker when the screen lock
-class ScreenLockObserver : public chromeos::PowerManagerClient::Observer,
+class ScreenLockObserver : public chromeos::SessionManagerClient::Observer,
public content::NotificationObserver {
public:
ScreenLockObserver() : session_started_(false) {
@@ -68,10 +68,10 @@ class ScreenLockObserver : public chromeos::PowerManagerClient::Observer,
switch (type) {
case chrome::NOTIFICATION_LOGIN_USER_CHANGED: {
// Register Screen Lock only after a user has logged in.
- chromeos::PowerManagerClient* power_manager =
- chromeos::DBusThreadManager::Get()->GetPowerManagerClient();
- if (!power_manager->HasObserver(this))
- power_manager->AddObserver(this);
+ chromeos::SessionManagerClient* session_manager =
+ chromeos::DBusThreadManager::Get()->GetSessionManagerClient();
+ if (!session_manager->HasObserver(this))
+ session_manager->AddObserver(this);
break;
}
@@ -199,8 +199,7 @@ void ScreenLocker::OnLoginSuccess(
content::Source<Profile>(profile),
content::Details<const GoogleServiceSigninSuccessDetails>(&details));
}
- DBusThreadManager::Get()->GetPowerManagerClient()->
- NotifyScreenUnlockRequested();
+ DBusThreadManager::Get()->GetSessionManagerClient()->RequestUnlockScreen();
if (login_status_consumer_)
login_status_consumer_->OnLoginSuccess(username, password, pending_requests,
@@ -286,9 +285,6 @@ void ScreenLocker::Show() {
new ScreenLocker(UserManager::Get()->GetLoggedInUser());
locker->Init();
} else {
- // PowerManager re-sends lock screen signal if it doesn't
- // receive the response within timeout. Just send complete
- // signal.
DVLOG(1) << "Show: locker already exists. Just sending completion event.";
DBusThreadManager::Get()->GetPowerManagerClient()->
NotifyScreenLockCompleted();
« no previous file with comments | « chrome/browser/chromeos/login/login_performer.cc ('k') | chrome/browser/chromeos/notifications/system_notification.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698