Another small batch of Junit test for errors in the resolver

compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 package com.google.dart.compiler.resolver;
 
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Objects;
 import com.google.dart.compiler.DartCompilerContext;
 import com.google.dart.compiler.ErrorCode;
@@ skipping 71 matching lines @@
 
     @Override
     boolean isStaticContext() {
       return isStatic;
     }
 
     @Override
     boolean isFactoryContext() {
       return isFactory;
     }
-    
+
     @Override
     protected EnclosingElement getEnclosingElement() {
       return enclosingElement;
     }
 
     @Override
     public Element visitClass(DartClass node) {
       assert !ElementKind.of(currentHolder).equals(ElementKind.CLASS) : "nested class?";
       beginClassContext(node);
       EnclosingElement previousEnclosingElement = enclosingElement;
@@ skipping 109 matching lines @@
         ResolutionContext previous = context;
         context = context.extend(element.getName());
         EnclosingElement previousEnclosingElement = enclosingElement;
         enclosingElement = element;
         resolveFunction(method.getFunction(), element);
         enclosingElement = previousEnclosingElement;
         context = previous;
       }
       return null;
     }
-    
+
     @Override
     protected void resolveFunctionWithParameters(DartFunction node, MethodElement element) {
       super.resolveFunctionWithParameters(node, element);
       // Bind "formal initializers" to fields.
       if (node.getParent() instanceof DartMethodDefinition) {
         DartMethodDefinition method = (DartMethodDefinition) node.getParent();
         for (DartParameter parameter : node.getParameters()) {
           if (parameter.getQualifier() instanceof DartThisExpression) {
             checkParameterInitializer(method, parameter);
           }
@@ skipping 339 matching lines @@
         if (modifiers.isStatic()) {
           resolutionError(method.getName(), ResolverErrorCode.FACTORY_CANNOT_BE_STATIC);
         }
         if (modifiers.isAbstract()) {
           resolutionError(method.getName(), ResolverErrorCode.FACTORY_CANNOT_BE_ABSTRACT);
         }
 
         if (modifiers.isConstant()) {
           // Allow const factory ... native ... ; type of constructors, used in core libraries
           DartBlock dartBlock = method.getFunction().getBody();
-          if (dartBlock == null  || !(dartBlock instanceof DartNativeBlock)) { 
+          if (dartBlock == null  || !(dartBlock instanceof DartNativeBlock)) {
             resolutionError(method.getName(), ResolverErrorCode.FACTORY_CANNOT_BE_CONST);
           }
         }
       }
       // TODO(ngeoffray): Add more checks on the modifiers. For
       // example const and missing body.
     }
 
     private void checkConstructor(MethodElement element, DartMethodDefinition method) {
       if (Elements.isNonFactoryConstructor(element) && method.getFunction() != null
           && method.getFunction().getReturnTypeNode() != null) {
-        resolutionError(method, ResolverErrorCode.CONSTRUCTOR_CANNOT_HAVE_RETURN_TYPE);
+        resolutionError(method.getFunction().getReturnTypeNode(),
+            ResolverErrorCode.CONSTRUCTOR_CANNOT_HAVE_RETURN_TYPE);
       }
     }
 
     private void checkUniqueName(EnclosingElement holder, Element e) {
       Element other = lookupElementByName(holder, e.getName(), e.getModifiers());
       assert e != other : "forgot to call checkUniqueName() before adding to the class?";
       if (other != null) {
         ElementKind eKind = ElementKind.of(e);
         ElementKind oKind = ElementKind.of(other);
 
@@ skipping 58 matching lines @@
      */
     private void reportDuplicateDeclaration(ErrorCode errorCode, Element element) {
       String name =
           element instanceof MethodElement
               ? Elements.getRawMethodName((MethodElement) element)
               : element.getName();
       resolutionError(element.getNameLocation(), errorCode, name);
     }
   }
 }