Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: runtime/vm/native_entry.h

Issue 10693071: Use VM type cast and save handles. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/native_entry.h
===================================================================
--- runtime/vm/native_entry.h (revision 9315)
+++ runtime/vm/native_entry.h (working copy)
@@ -56,16 +56,13 @@
// Natives should throw an exception if an illegal argument is passed.
// type name = value.
#define GET_NATIVE_ARGUMENT(type, name, value) \
- type& name = type::Handle(); \
- { \
- const Instance& __instance__ = Instance::CheckedHandle(value); \
- if (!__instance__.Is##type()) { \
- GrowableArray<const Object*> __args__; \
- __args__.Add(&__instance__); \
- Exceptions::ThrowByType(Exceptions::kIllegalArgument, __args__); \
- } \
- name ^= __instance__.raw(); \
- }
+ const Instance& __##name##_instance__ = Instance::CheckedHandle(value); \
+ if (!__##name##_instance__.Is##type()) { \
+ GrowableArray<const Object*> __args__; \
+ __args__.Add(&__##name##_instance__); \
+ Exceptions::ThrowByType(Exceptions::kIllegalArgument, __args__); \
+ } \
+ const type& name = type::Cast(__##name##_instance__);
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698