Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/dart_entry_test.cc

Issue 10693071: Use VM type cast and save handles. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/dart_api_impl.cc ('K') | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/debugger.cc » ('j') | runtime/vm/debugger_api_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_entry_test.cc
===================================================================
--- runtime/vm/dart_entry_test.cc (revision 9306)
+++ runtime/vm/dart_entry_test.cc (working copy)
@@ -68,9 +68,7 @@
const Object& retval = Object::Handle(
DartEntry::InvokeStatic(function, arguments, kNoArgumentNames));
EXPECT(retval.IsError());
- Error& error = Error::Handle();
- error ^= retval.raw();
- EXPECT_SUBSTRING("++++", error.ToErrorCString());
+ EXPECT_SUBSTRING("++++", Error::Cast(retval).ToErrorCString());
}
@@ -110,9 +108,7 @@
DartEntry::InvokeDynamic(
instance, function, arguments, kNoArgumentNames));
EXPECT(retval.IsError());
- Error& error = Error::Handle();
- error ^= retval.raw();
- EXPECT_SUBSTRING("++++", error.ToErrorCString());
+ EXPECT_SUBSTRING("++++", Error::Cast(retval).ToErrorCString());
}
#endif // TARGET_ARCH_IA32 || TARGET_ARCH_X64.
« runtime/vm/dart_api_impl.cc ('K') | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/debugger.cc » ('j') | runtime/vm/debugger_api_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698