Use VM type cast and save handles.

runtime/vm/debugger_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_debugger_api.h"
 
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_state.h"
 #include "vm/debugger.h"
 #include "vm/isolate.h"
 #include "vm/object_store.h"
 
 namespace dart {
 
-#define UNWRAP_AND_CHECK_PARAM(type, var, param)                              \
-  do {                                                                        \
-    const Object& tmp = Object::Handle(Api::UnwrapHandle(param));             \
-    if (tmp.IsNull()) {                                                       \
-      return Api::NewError("%s expects argument '%s' to be non-null.",        \
-                           CURRENT_FUNC, #param);                             \
-    } else if (tmp.IsApiError()) {                                            \
-      return param;                                                           \
-    } else if (!tmp.Is##type()) {                                             \
-      return Api::NewError("%s expects argument '%s' to be of type %s.",      \
-                           CURRENT_FUNC, #param, #type);                      \
-    }                                                                         \
-    var ^= tmp.raw();                                                         \
-  } while (0);
+#define UNWRAP_AND_CHECK_PARAM(type, var, param)                               \
+  type& var = type::Handle();                                                  \
+  do {                                                                         \
+    const Object& tmp = Object::Handle(Api::UnwrapHandle(param));              \
+    if (tmp.IsNull()) {                                                        \
+      return Api::NewError("%s expects argument '%s' to be non-null.",         \
+                           CURRENT_FUNC, #param);                              \
+    } else if (tmp.IsApiError()) {                                             \
+      return param;                                                            \
+    } else if (!tmp.Is##type()) {                                              \
+      return Api::NewError("%s expects argument '%s' to be of type %s.",       \
+                           CURRENT_FUNC, #param, #type);                       \
+    }                                                                          \
+    var ^= tmp.raw();                                                          \
+  } while (0)
 
 
-#define CHECK_AND_CAST(type, var, param)                                      \
-  if (param == NULL) {                                                        \
-    return Api::NewError("%s expects argument '%s' to be non-null.",          \
-                         CURRENT_FUNC, #param);                               \
-  }                                                                           \
-  type* var = reinterpret_cast<type*>(param);
+#define CHECK_AND_CAST(type, var, param)                                       \
+  type* var = NULL;                                                            \
+  do {                                                                         \
+    if (param == NULL) {                                                       \
+      return Api::NewError("%s expects argument '%s' to be non-null.",         \
+                           CURRENT_FUNC, #param);                              \
+    }                                                                          \
+    var = reinterpret_cast<type*>(param);                                      \
+  } while (0)
 
 
-#define CHECK_NOT_NULL(param)                                                 \
-  if (param == NULL) {                                                        \
-    return Api::NewError("%s expects argument '%s' to be non-null.",          \
-                         CURRENT_FUNC, #param);                               \
+#define CHECK_NOT_NULL(param)                                                  \
+  if (param == NULL) {                                                         \
+    return Api::NewError("%s expects argument '%s' to be non-null.",           \
+                         CURRENT_FUNC, #param);                                \
   }
 
 
 DART_EXPORT intptr_t Dart_CacheObject(Dart_Handle object_in) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   const Object& obj = Object::Handle(Api::UnwrapHandle(object_in));
   if (obj.IsApiError()) {
     return -1;
   }
@@ skipping 149 matching lines @@
   CHECK_AND_CAST(ActivationFrame, frame, activation_frame);
   return Api::NewHandle(isolate, frame->GetLocalVariables());
 }
 
 
 DART_EXPORT Dart_Handle Dart_SetBreakpoint(
                             Dart_Handle script_url_in,
                             intptr_t line_number) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-
-  String& script_url = String::Handle();
   UNWRAP_AND_CHECK_PARAM(String, script_url, script_url_in);
-
   Debugger* debugger = isolate->debugger();
   ASSERT(debugger != NULL);
   SourceBreakpoint* bpt =
       debugger->SetBreakpointAtLine(script_url, line_number);
   if (bpt == NULL) {
     return Api::NewError("%s: could not set breakpoint at line %d in '%s'",
                          CURRENT_FUNC, line_number, script_url.ToCString());
   }
   return Dart_NewInteger(bpt->id());
 }
 
 
 // TODO(hausner): remove this function.
 DART_EXPORT Dart_Handle Dart_SetBreakpointAtLine(
                             Dart_Handle script_url_in,
                             Dart_Handle line_number_in,
                             Dart_Breakpoint* breakpoint) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-
-  String& script_url = String::Handle();
-  Integer& line_number = Integer::Handle();
   UNWRAP_AND_CHECK_PARAM(String, script_url, script_url_in);
   UNWRAP_AND_CHECK_PARAM(Integer, line_number, line_number_in);
   CHECK_NOT_NULL(breakpoint);
 
   if (!line_number.IsSmi()) {
     return Api::NewError("%s: line number out of range", CURRENT_FUNC);
   }
   intptr_t line = line_number.AsInt64Value();
 
   const char* msg = CheckIsolateState(isolate);
@@ skipping 47 matching lines @@
 }
 
 
 DART_EXPORT Dart_Handle Dart_SetBreakpointAtEntry(
                             Dart_Handle library_in,
                             Dart_Handle class_name_in,
                             Dart_Handle function_name_in,
                             Dart_Breakpoint* breakpoint) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-
-  Library& library = Library::Handle();
-  String& class_name = String::Handle();
-  String& function_name = String::Handle();
   UNWRAP_AND_CHECK_PARAM(Library, library, library_in);
   UNWRAP_AND_CHECK_PARAM(String, class_name, class_name_in);
   UNWRAP_AND_CHECK_PARAM(String, function_name, function_name_in);
   CHECK_NOT_NULL(breakpoint);
 
   const char* msg = CheckIsolateState(isolate);
   if (msg != NULL) {
     return Api::NewError(msg);
   }
 
@@ skipping 67 matching lines @@
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   isolate->debugger()->SetStepOut();
   return Api::True(isolate);
 }
 
 
 DART_EXPORT Dart_Handle Dart_GetInstanceFields(Dart_Handle object_in) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-  Instance& obj = Instance::Handle();
   UNWRAP_AND_CHECK_PARAM(Instance, obj, object_in);
   return Api::NewHandle(isolate, isolate->debugger()->GetInstanceFields(obj));
 }
 
 
 DART_EXPORT Dart_Handle Dart_GetStaticFields(Dart_Handle cls_in) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-  Class& cls = Class::Handle();
   UNWRAP_AND_CHECK_PARAM(Class, cls, cls_in);
   return Api::NewHandle(isolate, isolate->debugger()->GetStaticFields(cls));
 }
 
 
 DART_EXPORT Dart_Handle Dart_GetLibraryFields(intptr_t library_id) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   const Library& lib =
       Library::Handle(isolate, Library::GetLibrary(library_id));
@@ skipping 14 matching lines @@
     return Api::NewError("%s: %d is not a valid library id",
                          CURRENT_FUNC, library_id);
   }
   return Api::NewHandle(isolate, isolate->debugger()->GetGlobalFields(lib));
 }
 
 
 DART_EXPORT Dart_Handle Dart_GetObjClass(Dart_Handle object_in) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-  Instance& obj = Instance::Handle();
   UNWRAP_AND_CHECK_PARAM(Instance, obj, object_in);
   return Api::NewHandle(isolate, obj.clazz());
 }
 
 
 DART_EXPORT Dart_Handle Dart_GetObjClassId(Dart_Handle object_in,
                                            intptr_t* class_id) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-  Instance& obj = Instance::Handle();
   UNWRAP_AND_CHECK_PARAM(Instance, obj, object_in);
   CHECK_NOT_NULL(class_id);
   *class_id = Class::Handle(obj.clazz()).id();
   return Api::True(isolate);
 }
 
 
 DART_EXPORT Dart_Handle Dart_GetSuperclass(Dart_Handle cls_in) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-  Class& cls = Class::Handle();
   UNWRAP_AND_CHECK_PARAM(Class, cls, cls_in);
   return Api::NewHandle(isolate, cls.SuperClass());
 }
 
 
 DART_EXPORT Dart_Handle Dart_GetClassInfo(
                             intptr_t cls_id,
                             Dart_Handle* class_name,
                             intptr_t* library_id,
                             intptr_t* super_class_id,
@@ skipping 30 matching lines @@
 DART_EXPORT Dart_Handle Dart_ScriptGetSource(
                             intptr_t library_id,
                             Dart_Handle script_url_in) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   const Library& lib = Library::Handle(Library::GetLibrary(library_id));
   if (lib.IsNull()) {
     return Api::NewError("%s: %d is not a valid library id",
                          CURRENT_FUNC, library_id);
   }
-  String& script_url = String::Handle();
   UNWRAP_AND_CHECK_PARAM(String, script_url, script_url_in);
   const Script& script = Script::Handle(lib.LookupScript(script_url));
   if (script.IsNull()) {
     return Api::NewError("%s: script '%s' not found in library '%s'",
                          CURRENT_FUNC, script_url.ToCString(),
                          String::Handle(lib.url()).ToCString());
   }
   return Api::NewHandle(isolate, script.source());
 }
 
 
 DART_EXPORT Dart_Handle Dart_GetScriptSource(
                             Dart_Handle library_url_in,
                             Dart_Handle script_url_in) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-  String& library_url = String::Handle();
   UNWRAP_AND_CHECK_PARAM(String, library_url, library_url_in);
-  String& script_url = String::Handle();
   UNWRAP_AND_CHECK_PARAM(String, script_url, script_url_in);
 
   const Library& library = Library::Handle(Library::LookupLibrary(library_url));
   if (library.IsNull()) {
     return Api::NewError("%s: library '%s' not found",
                          CURRENT_FUNC, library_url.ToCString());
   }
 
   const Script& script = Script::Handle(library.LookupScript(script_url));
   if (script.IsNull()) {
     return Api::NewError("%s: script '%s' not found in library '%s'",
                          CURRENT_FUNC, script_url.ToCString(),
                          library_url.ToCString());
   }
 
   return Api::NewHandle(isolate, script.source());
 }
 
 
 DART_EXPORT Dart_Handle Dart_GetScriptURLs(Dart_Handle library_url_in) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-  String& library_url = String::Handle();
   UNWRAP_AND_CHECK_PARAM(String, library_url, library_url_in);
 
   const Library& library = Library::Handle(Library::LookupLibrary(library_url));
   if (library.IsNull()) {
     return Api::NewError("%s: library '%s' not found",
                          CURRENT_FUNC, library_url.ToCString());
   }
   const Array& loaded_scripts = Array::Handle(library.LoadedScripts());
   ASSERT(!loaded_scripts.IsNull());
   intptr_t num_scripts = loaded_scripts.Length();
@@ skipping 100 matching lines @@
   for (int i = 0; i < num_libs; i++) {
     lib ^= libs.At(i);
     ASSERT(!lib.IsNull());
     lib_url = lib.url();
     library_url_list.SetAt(i, lib_url);
   }
   return Api::NewHandle(isolate, library_url_list.raw());
 }
 
 }  // namespace dart