Issue 10693065: Make MACOSX_DEPLOYMENT_TARGET configurable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10693065: Make MACOSX_DEPLOYMENT_TARGET configurable. (Closed)

Created:
8 years, 5 months ago by Jakob Kummerow

Modified:
8 years, 5 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make MACOSX_DEPLOYMENT_TARGET configurable. BUG=v8:2151 Committed: https://code.google.com/p/v8/source/detail?r=11972

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	build/standalone.gypi	View		2 chunks	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

PTAQL. https://chromiumcodereview.appspot.com/10693065/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://chromiumcodereview.appspot.com/10693065/diff/1/build/standalone.gypi#newcode36 build/standalone.gypi:36: 'mac_deployment_target%': '10.5', The bump to 10.5 is intentional. ...

8 years, 5 months ago (2012-07-02 14:54:52 UTC) #1

Yang

8 years, 5 months ago (2012-07-02 14:56:27 UTC) #2

On 2012/07/02 14:54:52, Jakob wrote:
> PTAQL.
> 
> https://chromiumcodereview.appspot.com/10693065/diff/1/build/standalone.gypi
> File build/standalone.gypi (right):
> 
>
https://chromiumcodereview.appspot.com/10693065/diff/1/build/standalone.gypi#...
> build/standalone.gypi:36: 'mac_deployment_target%': '10.5',
> The bump to 10.5 is intentional. We follow Chromium here.

LGTM.

Expand Messages | Collapse Messages