Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: lib/compiler/implementation/ssa/optimize.dart

Issue 10693059: remove HIf.hasElse. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/nodes.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/optimize.dart
diff --git a/lib/compiler/implementation/ssa/optimize.dart b/lib/compiler/implementation/ssa/optimize.dart
index 27e382d4f6ac06bdf638c29d19c2a379134958bc..2be7fa922b411076b471252510ea3092f489f26a 100644
--- a/lib/compiler/implementation/ssa/optimize.dart
+++ b/lib/compiler/implementation/ssa/optimize.dart
@@ -1168,15 +1168,7 @@ class SsaTypeConversionInserter extends HBaseVisitor
}
for (HIf ifUser in notIfUsers) {
- if (ifUser.hasElse) {
- changeUsesDominatedBy(ifUser.elseBlock, input, convertedType);
- } else if (ifUser.joinBlock.predecessors.length == 1) {
- // If the join block has only one predecessor, then we know
- // the if block terminates. So any use of the instruction
- // after the join block should be changed to the new
- // instruction.
- changeUsesDominatedBy(ifUser.joinBlock, input, convertedType);
- }
+ changeUsesDominatedBy(ifUser.elseBlock, input, convertedType);
// TODO(ngeoffray): Also change uses for the then block on a HType
// that knows it is not of a specific Type.
}
« no previous file with comments | « lib/compiler/implementation/ssa/nodes.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698