runtime/bin/eventhandler_linux.h - Issue 10693039: Terminate event handler thread on isolate shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/eventhandler_linux.h

Issue 10693039: Terminate event handler thread on isolate shutdown. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/eventhandler_linux.h

diff --git a/runtime/bin/eventhandler_linux.h b/runtime/bin/eventhandler_linux.h

index 073ad6295ed1d7106ae431076e8ce2d4731b8b20..ded09073759d899da765fcf90c1ad6ddd7b05bac 100644

--- a/runtime/bin/eventhandler_linux.h

+++ b/runtime/bin/eventhandler_linux.h

@@ -94,6 +94,7 @@ class EventHandlerImplementation {

SocketData* GetSocketData(intptr_t fd);

void SendData(intptr_t id, Dart_Port dart_port, intptr_t data);

void StartEventHandler();

Søren Gjesse 2012/06/29 11:54:11 Should StartEventHandler be just Start then?

Mads Ager (google) 2012/06/29 14:30:24 Done. Thanks.

+ void Shutdown();

private:

intptr_t GetTimeout();

@@ -111,6 +112,7 @@ class EventHandlerImplementation {

HashMap socket_map_;

int64_t timeout_; // Time for next timeout.

Dart_Port timeout_port_;

+ bool shutdown_;

int interrupt_fds_[2];

int epoll_fd_;

};

« no previous file with comments | « runtime/bin/eventhandler.h ('k') | runtime/bin/eventhandler_linux.cc » ('j') | runtime/bin/eventhandler_linux.cc » ('J')