Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 10693002: HiDPI gear icon for about:memory (Closed)

Created:
8 years, 6 months ago by Nico
Modified:
8 years, 5 months ago
CC:
chromium-reviews, arv (Not doing code reviews), pam+watch_chromium.org
Visibility:
Public.

Description

HiDPI gear icon for about:memory BUG=134372 TEST=visual TBR=avi,flackr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144395 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144592

Patch Set 1 #

Patch Set 2 : Reland r144395 (was reverted in r144396) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M chrome/browser/browser_resources.grd View 2 chunks +11 lines, -9 lines 0 comments Download
A chrome/browser/resources/shared/images/2x/gear.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/shared/images/gear.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
TBR because it's just a new image. flackr, please double-check the chrome_html change.
8 years, 6 months ago (2012-06-27 04:11:53 UTC) #1
Avi (use Gerrit)
lgtm
8 years, 6 months ago (2012-06-27 05:03:36 UTC) #2
flackr
lgtm
8 years, 5 months ago (2012-06-27 12:01:43 UTC) #3
Nico
On 2012/06/27 12:01:43, flackr wrote: > lgtm Thanks! I had to revert this due to ...
8 years, 5 months ago (2012-06-27 14:47:57 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-06-27 22:35:41 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698