Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3436)

Unified Diff: chrome/browser/ui/browser_navigator_browsertest.cc

Issue 10692195: Consolidate Browser Creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_navigator.cc ('k') | chrome/browser/ui/browser_tab_restore_service_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_navigator_browsertest.cc
===================================================================
--- chrome/browser/ui/browser_navigator_browsertest.cc (revision 148382)
+++ chrome/browser/ui/browser_navigator_browsertest.cc (working copy)
@@ -68,15 +68,14 @@
Browser* BrowserNavigatorTest::CreateEmptyBrowserForType(Browser::Type type,
Profile* profile) {
- Browser* browser = Browser::CreateWithParams(
- Browser::CreateParams(type, profile));
+ Browser* browser = new Browser(Browser::CreateParams(type, profile));
chrome::AddBlankTab(browser, true);
return browser;
}
Browser* BrowserNavigatorTest::CreateEmptyBrowserForApp(Browser::Type type,
Profile* profile) {
- Browser* browser = Browser::CreateWithParams(
+ Browser* browser = new Browser(
Browser::CreateParams::CreateForApp(
Browser::TYPE_POPUP, "Test", gfx::Rect(), profile));
chrome::AddBlankTab(browser, true);
@@ -1243,7 +1242,7 @@
GURL url2("http://maps.google.com/#b");
// Create a panel.
- Browser* panel_browser = Browser::CreateWithParams(
+ Browser* panel_browser = new Browser(
Browser::CreateParams::CreateForApp(
Browser::TYPE_PANEL, "Test", gfx::Rect(100, 100),
browser()->profile()));
« no previous file with comments | « chrome/browser/ui/browser_navigator.cc ('k') | chrome/browser/ui/browser_tab_restore_service_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698