Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: chrome/browser/ui/browser_navigator.cc

Issue 10692195: Consolidate Browser Creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_mac.cc ('k') | chrome/browser/ui/browser_navigator_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_navigator.cc
===================================================================
--- chrome/browser/ui/browser_navigator.cc (revision 148382)
+++ chrome/browser/ui/browser_navigator.cc (working copy)
@@ -58,7 +58,7 @@
// such Browser is located.
Browser* GetOrCreateBrowser(Profile* profile) {
Browser* browser = browser::FindTabbedBrowser(profile, false);
- return browser ? browser : Browser::Create(profile);
+ return browser ? browser : new Browser(Browser::CreateParams(profile));
}
// Change some of the navigation parameters based on the particular URL.
@@ -137,19 +137,15 @@
if (app_name.empty()) {
Browser::CreateParams browser_params(Browser::TYPE_POPUP, profile);
browser_params.initial_bounds = params->window_bounds;
- return Browser::CreateWithParams(browser_params);
+ return new Browser(browser_params);
}
- return Browser::CreateWithParams(
- Browser::CreateParams::CreateForApp(
- Browser::TYPE_POPUP, app_name, params->window_bounds,
- profile));
+ return new Browser(Browser::CreateParams::CreateForApp(
+ Browser::TYPE_POPUP, app_name, params->window_bounds, profile));
}
case NEW_WINDOW: {
// Make a new normal browser window.
- Browser* browser = new Browser(Browser::TYPE_TABBED, profile);
- browser->InitBrowserWindow();
- return browser;
+ return new Browser(Browser::CreateParams(profile));
}
case OFF_THE_RECORD:
// Make or find an incognito window.
« no previous file with comments | « chrome/browser/ui/browser_mac.cc ('k') | chrome/browser/ui/browser_navigator_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698