Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: chrome/browser/sessions/session_restore.cc

Issue 10692195: Consolidate Browser Creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sessions/session_restore.cc
===================================================================
--- chrome/browser/sessions/session_restore.cc (revision 148382)
+++ chrome/browser/sessions/session_restore.cc (working copy)
@@ -578,7 +578,8 @@
bool use_new_window = disposition == NEW_WINDOW;
- Browser* browser = use_new_window ? Browser::Create(profile_) : browser_;
+ Browser* browser = use_new_window ?
+ new Browser(Browser::CreateParams(profile_)) : browser_;
RecordAppLaunchForTab(browser, tab, selected_index);
@@ -663,7 +664,7 @@
Browser* FinishedTabCreation(bool succeeded, bool created_tabbed_browser) {
Browser* browser = NULL;
if (!created_tabbed_browser && always_create_tabbed_browser_) {
- browser = Browser::Create(profile_);
+ browser = new Browser(Browser::CreateParams(profile_));
if (urls_to_open_.empty()) {
// No tab browsers were created and no URLs were supplied on the command
// line. Add an empty URL, which is treated as opening the users home
@@ -927,7 +928,7 @@
params.initial_bounds = bounds;
params.initial_show_state = show_state;
params.is_session_restore = true;
- return Browser::CreateWithParams(params);
+ return new Browser(params);
}
void ShowBrowser(Browser* browser, int selected_tab_index) {
« no previous file with comments | « chrome/browser/profiles/profile_manager_unittest.cc ('k') | chrome/browser/sessions/session_restore_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698