Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 10692187: Added Crankshaft support for setters. (Closed)

Created:
8 years, 5 months ago by Sven Panne
Modified:
8 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Added Crankshaft support for setters. Refactored ComputeLoadStoreField a bit on the way to clarify a bit what it actually does. Committed: https://code.google.com/p/v8/source/detail?r=12072

Patch Set 1 #

Patch Set 2 : Reverted accidental es5_readonly change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -25 lines) Patch
M src/hydrogen.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +68 lines, -25 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-125148.js View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years, 5 months ago (2012-07-12 12:40:39 UTC) #1
Jakob Kummerow
8 years, 5 months ago (2012-07-12 14:13:07 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698