Issue 10692185: Couple the enumeration index of a property to the size of the descriptor array where it first appea…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10692185: Couple the enumeration index of a property to the size of the descriptor array where it first appea… (Closed)

Created:
8 years, 5 months ago by Toon Verwaest

Modified:
8 years, 5 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Couple the enumeration index of a property to the size of the descriptor array where it first appeared. Committed: https://code.google.com/p/v8/source/detail?r=12066

Patch Set 2 : Adding assert in Set #

Total comments: 1

Patch Set 3 : Use the enumeration index of the LastAdded descriptor for appending. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -111 lines)			Patch
M	src/bootstrapper.cc	View	1 2	8 chunks	+42 lines, -75 lines	0 comments	Download
M	src/factory.cc	View	1 2	4 chunks	+17 lines, -17 lines	0 comments	Download
M	src/objects.h	View	1 2	4 chunks	+15 lines, -7 lines	0 comments	Download
M	src/objects.cc	View	1 2	4 chunks	+25 lines, -10 lines	0 comments	Download
M	src/objects-inl.h	View	1 2	2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/property.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

danno

https://chromiumcodereview.appspot.com/10692185/diff/3005/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/10692185/diff/3005/src/objects.h#newcode2548 src/objects.h:2548: const WhitenessWitness&); Remove the need for descriptor_number as discussed ...

8 years, 5 months ago (2012-07-12 11:26:08 UTC) #2

lgtm